Sent campaigns were editable and PATCH bodies were not validated #12

New issue

Closed

opened 2026-10-14 23:16:25 -04:00 by vmanne-poc · 0 comments

vmanne-poc commented

2026-10-14 23:16:25 -04:00

Owner

Problem:

Sent campaigns could still be edited.
PATCH bodies for campaigns and templates were typed as Partial<Dto>, which TypeScript erases at runtime, so the ValidationPipe skipped them.

Fix: only DRAFT/SCHEDULED campaigns can be edited or scheduled; explicit UpdateCampaignDto / UpdateTemplateDto classes are validated.

Tests: e2e "validates campaign updates" (non-string subject -> 400) and "refuses to ... edit a campaign that was already sent".

Fixed in v0.7.0.

**Problem:** - Sent campaigns could still be edited. - PATCH bodies for campaigns and templates were typed as `Partial<Dto>`, which TypeScript erases at runtime, so the ValidationPipe skipped them. **Fix:** only DRAFT/SCHEDULED campaigns can be edited or scheduled; explicit `UpdateCampaignDto` / `UpdateTemplateDto` classes are validated. **Tests:** e2e "validates campaign updates" (non-string subject -> 400) and "refuses to ... edit a campaign that was already sent". Fixed in `v0.7.0`.

vmanne-poc added this to the Phase 7: Segmentation, access control & e2e tests (v0.7.0) milestone

2026-10-14 23:16:25 -04:00

vmanne-poc

2026-10-14 23:16:25 -04:00